Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder in layer list? #66

Closed
muesliq opened this issue Jan 11, 2017 · 6 comments
Closed

Folder in layer list? #66

muesliq opened this issue Jan 11, 2017 · 6 comments

Comments

@muesliq
Copy link
Collaborator

muesliq commented Jan 11, 2017

Mapbox Studio supports folders via metadata properties, if I'm not mistaken. I am not proposing to do the same, as this is a proprietary approach.

Yet there's a non-proprietary possibility to do the same: We could automatically bundle all adjacent layers that start with the same word into a folder.

Look at this example:

screen shot 2017-01-11 at 10 11 13

This would look like this:

  • background
  • landcover-glacier
  • landuse..
  • park..
  • landuse..
  • landcover..
  • waterway..
  • water-offset

Less than half the length.

@lukasmartinelli
Copy link
Collaborator

Very good idea for grouping by the prefix!!!!

I also have problems working with 100 layers style to still find my styles.
I would like that feature as well - not much time left to do all these cool features but we'll see.

The only implementation issue might be that it makes drag and drop harder.

@lukasmartinelli
Copy link
Collaborator

Note to myself: I can probably reuse the collapse components to make this very straightforward.

@muesliq
Copy link
Collaborator Author

muesliq commented Jan 11, 2017

By the way, this feature would incentivise proper layer naming :-)

lukasmartinelli added a commit that referenced this issue Jan 11, 2017
lukasmartinelli added a commit that referenced this issue Jan 11, 2017
@lukasmartinelli
Copy link
Collaborator

Works now! It's quite a hack implementation wise because otherwise drag and drop get's broken.
But for using it is it works ok (hope it doesn't confuse users though).

Especially the group reordering can be confusing at first.
Because when you move a layer out of a prefix group or into it it will form a new group.
Still think we should keep it though.

Thanks for pushing me - wouldn't have implemented it otherwise but the trick with the prefix is very neat (and does not make us copycats - which is even more important to me).

OSM Liberty has 100 layers - and there it really helps organizing.

screenshot from 2017-01-11 19-41-57

@muesliq muesliq closed this as completed Jan 12, 2017
@muesliq
Copy link
Collaborator Author

muesliq commented Jan 12, 2017

I would close folders by default, otherwise the benefit is limited.

@lukasmartinelli
Copy link
Collaborator

It is now collapsed by default e5fbe3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants