This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
Migrate client management from service to fused location api implementation #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n api implementation
ecgreb
force-pushed
the
173-binder-proxy-class-cast-exception
branch
from
be66968
to
ab702be
Compare
…iceDelegate "Impl" is usually reserved for a class that implements an interface. The name "Delegate" better describes the pattern in use here http://best-practice-software-engineering.ifs.tuwien.ac.at/patterns/delegation.html.
ecgreb
changed the title
sarahsnow1
approved these changes
Apr 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As a prerequisite to adding IPC support (#173), all non-parcelable objects must be removed from the
FusedLocationProviderServiceinterface. This patch removes all instances of theLostApiClientas a parameter fromFusedLocationProviderServicemethods and migrates client management intoFusedLocationProviderApiImpl.Proposed Changes
LostApiClientfromFusedLocationProviderServiceinterface.FusedLocationProviderApiImplandLostClientManagerto add/remove listeners, callbacks, and pending intents.FusedLocationProviderServiceImpl->FusedLocationProviderServiceDelegatesince this class does not implement an interface but rather follows the delegation pattern using composition.http://best-practice-software-engineering.ifs.tuwien.ac.at/patterns/delegation.html