Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need the user to set the autotroph silicifier flag? #337

Open
mnlevy1981 opened this issue May 22, 2019 · 0 comments
Open

Do we need the user to set the autotroph silicifier flag? #337

mnlevy1981 opened this issue May 22, 2019 · 0 comments
Assignees
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

One alternative would be to replace all if (silicifier) statements with if (kSiO3 > 0). This would also affect the python logic for parsing the diagnostics JSON file, since there are some blocks in the YAML like

((autotroph_sname))_SiO3_lim_surf :
   dependencies :
      ((autotroph_silicifier)) : true
   longname : ((autotroph_lname)) SiO3 Limitation, Surface
   units : 1
   vertical_grid : none
   frequency : medium
   operator : average

And the python code that determines ((autotroph_silicifier)) will need to be updated.

(This offers a different solution to part of #278 -- we would definitely not want to base the logical checks on the diagnostic indices, but perhaps some logical checks should be based on the value of r8 settings rather than logical settings)

At the very least, we should ensure that silicifier .eqv. (kSiO3 > 0) in marbl_settings_consistency_check()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MARBL 1.0.0 Release
Unsorted open tickets
Development

No branches or pull requests

1 participant