Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GetLatestReleaseFromGitHub to use Release.GetAll() to include prerelease releases #21

Closed
marcduiker opened this issue Apr 29, 2019 · 3 comments
Closed

Change GetLatestReleaseFromGitHub to use Release.GetAll() to include prerelease releases #21

marcduiker opened this issue Apr 29, 2019 · 3 comments
Assignees
@marcduiker
Labels
bug Something isn't working

Comments

@marcduiker
Copy link
Owner

Currently the Release.GetLatest() method is used but this only returns releases which are not prerelease. Some repositories such as azure-functions-kafka-extension only have prerelease releases and therefore do not get stored or posted to Twitter.
@marcduiker marcduiker self-assigned this Apr 29, 2019
@marcduiker marcduiker added the bug Something isn't working label Apr 29, 2019
@marcduiker marcduiker mentioned this issue Apr 29, 2019
Merged
@marcduiker
Copy link
Owner Author

Fixed in release v1.3.3

@marcduiker
Copy link
Owner Author

Not fixed when Release.GetAll is used. Reverted back to Release.GetLatest for now to prevent NullRefExceptions.

@marcduiker marcduiker reopened this Apr 29, 2019
@marcduiker
Copy link
Owner Author

Fixed and verified in release 1.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcduiker marcduiker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcduiker