Suggestions

[ArthurHoaro]

It seems to be a solid project for such a short development time! 👍

If I may suggest a few improvements after a quick glance at the project:

• it seems to have a lot of dependencies, maybe necessary but undocumented (PHP Excel ?)
• due to these dependencies, required PHP extensions should be added to the README
• you should explain how to get it started with SQLite as the default .env contains MySQL settings
• almost no unit tests 👀

[MarceauKa]

Hi @ArthurHoaro and thank you for your feedback! I'll try to answer all of your interrogations.

• I've tried to document all php and js dependencies here
• I don't think we need to suggest PHP extension, Laravel do this for us in its composer.json (no php extension required for excel)
• Additional documentation is now described here
• Yeah, I confess 👏(but no unit tests, only E2E tests)

[wyred]

I'm not familiar with node. I followed the installation instructions here (https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/setting-up-node-on-ec2-instance.html) and managed to get it installed, but I'm getting a permissions error.

[previous exception] [object] (Symfony\\Component\\Process\\Exception\\ProcessFailedException(code: 0): The command \"'/home/ec2-user/.nvm/versions/node/v12.11.1/bin/node' '/var/www/shaarli/vendor/nesk/rialto/src/node-process/serve.js' '/var/www/shaarli/vendor/nesk/puphpeteer/src/PuppeteerConnectionDelegate.js' '{\"idle_timeout\":60,\"log_node_console\":false,\"log_browser_console\":false}'\" failed.

Exit Code: 126(Invoked command cannot execute)

Working directory: /var/www/shaarli/public

Output:
================


Error Output:
================
sh: /home/ec2-user/.nvm/versions/node/v12.11.1/bin/node: Permission denied
sh: line 0: exec: /home/ec2-user/.nvm/versions/node/v12.11.1/bin/node: cannot execute: Permission denied
 at /var/www/shaarli/vendor/nesk/rialto/src/ProcessSupervisor.php:309)

Would you be able to share what your installation procedure is in order to get the "PDF Archiving" feature to work?

Update: I've managed to get node to run by not using sync for queues. Probably because the webserver user (nginx/apache) in my case does not have permissions to run node, which was installed as ec2-user. I've switched to database queues and I've setup supervisor for it.

However, I run into dependancy hell.

Nesk\Rialto\Exceptions\Node\FatalException: Failed to launch chrome!
/var/www/shaarli/node_modules/puppeteer/.local-chromium/linux-686378/chrome-linux/chrome: error while loading shared libraries: libXss.so.1: cannot open shared object file: No such file or directory

If you don't know the solution for this, please ignore my earlier request.

[MarceauKa]

Yeah, I experienced the same issue on CentOS.

I had to install some dependencies:

yum install ipa-gothic-fonts xorg-x11-fonts-100dpi xorg-x11-fonts-75dpi xorg-x11-utils xorg-x11-fonts-cyrillic xorg-x11-fonts-Type1 xorg-x11-fonts-misc -y