Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra HTML code in "Title" field when adding URL #19

Closed
wyred opened this issue Oct 15, 2019 · 5 comments
Closed

Extra HTML code in "Title" field when adding URL #19

wyred opened this issue Oct 15, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@wyred
Copy link
Contributor

wyred commented Oct 15, 2019 •
edited
Loading

At the "Add Link" form, I fill in the URL, the Title and Content is then auto-filled. However, the Title field has some extra HTML codes.

shaarli-addurl

This is on v1.2.16

Edit: Looks like this happens only when there's a / in the title
@MarceauKa MarceauKa added the bug Something isn't working label Oct 15, 2019
@MarceauKa
Copy link
Owner

Ok, a patch will be released in the next release. The WebParser needs some improvements in the future.

@MarceauKa
Copy link
Owner

Released in 1.2.17, you'd be in love with the new shaarli:update command and the new dark mode 😊

@wyred
Copy link
Contributor Author

wyred commented Oct 16, 2019

Sorry to be so annoying, here's another small problem I found.

htmlchars

@MarceauKa
Copy link
Owner

The WebParser component needs some refactoring. It'll use Symfony DomCrawler for better results. Feel free to make a PR :)

@MarceauKa
Copy link
Owner

Updated in 1.2.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wyred @MarceauKa