Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - ExploreConfig not working in Glados2 and Glados3 #21

Closed
MSCL opened this issue Oct 11, 2022 · 2 comments
Closed

Bug - ExploreConfig not working in Glados2 and Glados3 #21

MSCL opened this issue Oct 11, 2022 · 2 comments

Comments

@MSCL
Copy link

MSCL commented Oct 11, 2022

First of all: Great Project! Unfortunately I encountered a little bug.

The provided ExploreConfig explore property in the Glados2 and Glados3 implementation has no influence.

I use Glados version 1.1.5 .
As far I can see it, you did miss to forward the property to the Glados constructors in line 256 and 331 to make it work correctly.

BTW. Nice university, I also studied there some years ago! :) .
@MSCL MSCL mentioned this issue Oct 11, 2022
Merged
@MarcelGarus
Copy link
Owner

Good catch and thanks for the PR!

And nice to meet a fellow HPI person. If you're ever in Potsdam and want to meet up for a drink, hit me up. 😅

@MarcelGarus
Copy link
Owner

This is now published as 1.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MSCL @MarcelGarus