Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '_positions.isNotEmpty': ScrollController not attached to any scroll views. #44

Closed
wants to merge 1 commit into from
Closed

Conversation

nt4f04uNd
Copy link

@nt4f04uNd nt4f04uNd commented Sep 7, 2020

I have a big application and I used your widget package (I have music player and I use it for my song title in the player page, like in YT Music), though when I replace it fast in the widget tree, i.e. fast tap on my "next song" button, it turns out there's a bug in it and the following exception is being thrown:
AssertionError('Fix 'package:flutter/src/widgets/scroll_controller.dart': Failed assertion: line 176 pos 12: '_positions.isNotEmpty': ScrollController not attached to any scroll views.').

This PR fixes it.

Videos:
Error
Same thing but with my fix

…rtion: line 176 pos 12: '_positions.isNotEmpty': ScrollController not attached to any scroll views.
@MarcelGarus
Copy link
Owner

MarcelGarus commented Sep 10, 2020

Thanks for the PR! Another PR also touched the same code, I merged both manually.
The resulting package is published as 1.6.1

@amaljoe
Copy link

amaljoe commented Dec 30, 2021

Hi, I am still having this issue in 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants