Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate buffer manager #31

Closed
MarcellPerger1 opened this issue Apr 5, 2022 · 0 comments · Fixed by #39
Closed

Separate buffer manager #31

MarcellPerger1 opened this issue Apr 5, 2022 · 0 comments · Fixed by #39
Labels
internal change Improvement to only internals

Comments

@MarcellPerger1
Copy link
Owner

The World class has a lot of closely related buffer methods.
These could be extracted (together with the data) into a separate class with

  • those methods
  • the buffers (name of buffer = attribute name)

The aforementioned methods could then be used by doing (where this is renderer):

  • this.buffers.make or
  • this.buffers.setData etc.
@MarcellPerger1 MarcellPerger1 added enhancement New feature or request internal change Improvement to only internals and removed enhancement New feature or request labels Apr 6, 2022
@MarcellPerger1 MarcellPerger1 mentioned this issue Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal change Improvement to only internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate buffer manager MarcellPerger1/minecraft_clone_1
1 participant
@MarcellPerger1