Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move color-definition of build-state to global scope #232

Open
ehmkah opened this issue Oct 8, 2020 · 1 comment
Open

Move color-definition of build-state to global scope #232

ehmkah opened this issue Oct 8, 2020 · 1 comment
Assignees

Comments

@ehmkah
Copy link
Contributor

ehmkah commented Oct 8, 2020

Many different build-systems are supported and the state of the build is mapped to a color. This mapping is implemented in getBuildStatus. It would be nice to have a global defined mapping of states to color. It would make it

  • easier to define which color could be expected especially if you show different build-systems simultaneously
  • easier to define themes where the colors of build-state could be changed too (no idea whether thats useful)
  • easier to integrate new build-systems because colors are already defined

e.g for such a mapping could be (taken from https://github.com/marcells/node-build-monitor/blob/master/app/services/Tfs.js)

 const colorScheme = Object.freeze({
    succeeded:          'Green',
    partiallySucceeded: '#F8A800',
    failed:             'Red',
    canceled:           'Gray',
    inProgress:         '#0078D7',
    completed:          'Green',
    cancelling:         '#0078D7',
    postponed:          'Gray',
    notStarted:         'Gray',
    all:                'Gray'
  });
@marcells
Copy link
Owner

marcells commented Oct 9, 2020

Good idea. You can implement it, if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants