Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DOSDownload): add download from spaces task #15

Merged
merged 16 commits into from
Nov 7, 2020

Conversation

marceloavf
Copy link
Owner

@marceloavf marceloavf commented Nov 4, 2020

Description

Add feature to download files from DigitalOcean Spaces & multiples improvements overall.

BREAKING CHANGE: this release will change/improve a lot of things in multiple tasks (Delete & Upload), so may need to be a major release.

Pre-merge checklist

  • Test on Development task
  • Fix package size above limit
  • Add webpack
  • Fix missing icon in DOSDownload task
  • Fix "source folder" option being able to select files/folder in host
  • Fix matching pattern for "source folder" /home/vsts/work/r1/a/$(Agent.BuildDirectory)/test_folder_version

Resolves #8 #11 #2 #12

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #15 (6785499) into master (5ed7540) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #15      +/-   ##
===========================================
+ Coverage   99.49%   100.00%   +0.50%     
===========================================
  Files          14        18       +4     
  Lines         198       258      +60     
  Branches       24        20       -4     
===========================================
+ Hits          197       258      +61     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
...gitalOceanSpacesDelete/digitalOceanSpacesDelete.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDelete/tl.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDelete/utils/Delete.ts 100.00% <100.00%> (+4.34%) ⬆️
Tasks/DigitalOceanSpacesDelete/utils/Parameters.ts 100.00% <100.00%> (ø)
...alOceanSpacesDelete/utils/filterSemanticVersion.ts 100.00% <100.00%> (ø)
...lOceanSpacesDownload/digitalOceanSpacesDownload.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDownload/index.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDownload/tl.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDownload/utils/Download.ts 100.00% <100.00%> (ø)
...sks/DigitalOceanSpacesDownload/utils/Parameters.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed7540...6785499. Read the comment docs.

@marceloavf
Copy link
Owner Author

Having many 503 HTTP errors, maybe some maintenance with digital ocean services.

2020-11-07T16:38:35.7623028Z Deleting files from 'root' in bucket precisao-sistemas-test
2020-11-07T16:38:35.7627915Z Searching 'root' prefix for files to delete
2020-11-07T16:40:36.5820664Z Deleting files failed { ServiceUnavailable: Service is unavailable at this time.
2020-11-07T16:40:36.5822616Z     at Request.extractError (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:25091:35)
2020-11-07T16:40:36.5824135Z ##[debug]task result: Failed
2020-11-07T16:40:36.5827447Z     at Request.callListeners (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:22657:20)
2020-11-07T16:40:36.5828756Z     at Request.emit (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:22629:10)
2020-11-07T16:40:36.5829753Z     at Request.emit (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:21269:14)
2020-11-07T16:40:36.5830804Z     at Request.transition (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:20603:10)
2020-11-07T16:40:36.5831912Z     at AcceptorStateMachine.runTo (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:27391:12)
2020-11-07T16:40:36.5832943Z     at D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:27403:10
2020-11-07T16:40:36.5833914Z     at Request.<anonymous> (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:20619:9)
2020-11-07T16:40:36.5834940Z     at Request.<anonymous> (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:21271:12)
2020-11-07T16:40:36.5836271Z     at Request.callListeners (D:\a\_tasks\DigitalOcean_51857331-597a-4e02-8e5a-fbdea3f5d8f4\0.9.17\index.js:22667:18)
2020-11-07T16:40:36.5836788Z   message: 'Service is unavailable at this time.',
2020-11-07T16:40:36.5837388Z   code: 'ServiceUnavailable',
2020-11-07T16:40:36.5837786Z   region: null,
2020-11-07T16:40:36.5838121Z   time: 2020-11-07T16:40:36.577Z,
2020-11-07T16:40:36.5838562Z   requestId: 'not-available',
2020-11-07T16:40:36.5838990Z   extendedRequestId: 'not-available',
2020-11-07T16:40:36.5839435Z   cfId: undefined,
2020-11-07T16:40:36.5839788Z   statusCode: 503,
2020-11-07T16:40:36.5840178Z   retryable: true }

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marceloavf marceloavf merged commit c886ab3 into master Nov 7, 2020
@marceloavf marceloavf deleted the feat/download-task branch November 7, 2020 21:10
marceloavf pushed a commit that referenced this pull request Nov 7, 2020
# [1.0.0](v0.5.0...v1.0.0) (2020-11-07)

### Features

* **DOSDownload:** add digitalocean spaces download task ([#15](#15)) ([c886ab3](c886ab3))

### BREAKING CHANGES

* **DOSDownload:** This release change and improve a lot of things in multiple tasks (Delete & Upload).

* docs: update links to use repository instead of wiki
* chore: upgrade packages and node to v14
* fix(DOSDelete): refactor filter files
* refactor(DOSUpload): use common filter files
* feat: add task to download from space
* fix(DOSDownload): get stream errors on pipe and before
* test(DOSDownload): add error tests
* chore: reduce code duplication on tests
* test: refactor parameters tests
* docs(readme): add tips and tweaks links
* chore: remove unused package
* chore(DOSUpload): add matcher package
* chore: remove inner packages to allow webpack implementation
* chore: add webpack
* fix(DOSUpload): remove unused resource path
* fix(DOSDownload): source & target path, icon, getInput instead of path
@marceloavf
Copy link
Owner Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@marceloavf marceloavf added the released This is ready to use! label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This is ready to use!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download from Spaces?
1 participant