Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Logging metrics is not fully correct #2

Open
runk opened this issue Nov 27, 2019 · 0 comments
Open

Logging metrics is not fully correct #2

runk opened this issue Nov 27, 2019 · 0 comments

Comments

@runk
Copy link

runk commented Nov 27, 2019

  1. When tags are empty code is still sending them as "empty" chunk:

https://github.com/marceloboeira/aws-lambda-datadog/blob/master/src/logger.js#L6

So ideally there wouldn't be |# part at all.

  1. Time should be send as seconds, not microseconds: https://docs.datadoghq.com/integrations/amazon_lambda/?tab=awsconsole#deprecated-using-cloudwatch-logs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant