Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

BoJack client shard #36

Closed
marceloboeira opened this issue Aug 24, 2016 · 8 comments
Closed

BoJack client shard #36

marceloboeira opened this issue Aug 24, 2016 · 8 comments
Assignees
Milestone

Comments

@marceloboeira
Copy link
Owner

We need a special repository for the BoJack client shard, so that Crystal developers can install only the client, as we already have the Python client.

Client only, the console should remain under this repository.

@hugoabonizio If you want to be in charge of this you could create the bojack.cr repository that would be a client for BoJack, move the content from this repository to yours and also use the shard here to point to the Client class.

If you do so, I would like to ask to also rename the CLI command, from client to console to avoid any future misunderstandings.

I would like to as both @mauricioabreu and @hugoabonizio that the clients follow the release number of the server, so it is easy to identify compatible versions.

@mauricioabreu
Copy link
Collaborator

Hm, about the last parte (versioning): I don't know if it will work for Python.

Python does take in consideration the version number to upload a package to PyPI (Python Package Index). If a bug is fixed on the client package, it could not be updated.

@hugoabonizio
Copy link
Collaborator

@marceloboeira OK, I'm doing this!

@mauricioabreu you can update the PATCH version of the package, I think. So your package for BoJack v0.2.0 can be 0.2.0.1, for example.

@marceloboeira
Copy link
Owner Author

@hugoabonizio perfect!

I was not clear about the patch version. @mauricioabreu Thanks for remind us.

@mauricioabreu
Copy link
Collaborator

@marceloboeira yey, you are welcome :)

@hugoabonizio
Copy link
Collaborator

I created the repository https://github.com/hugoabonizio/bojack.cr and named the shard "bojack-client" to avoid conflicts.

To write the specs I'm suposing the user has BoJack already running at 127.0.0.1:5000, but to test on Travis I think I should include this repo as a development_depencency.

@marceloboeira
Copy link
Owner Author

@hugoabonizio take a look how the http://github.com/marceloboeira/bojack-kemal-heroku is doing this, I use bojack (this repo) as a shard and run the server in the same process. This way you "inject" bojack in the same process as a dependency.

Just remember to make it a development_dependency, in order to prevent circular references.

@marceloboeira
Copy link
Owner Author

As soon as you finish and release a stable version, we remove the code from here and close this issue.

@hugoabonizio
Copy link
Collaborator

Closed in #38.

@marceloboeira marceloboeira modified the milestones: v0.2.0, v0.1.2 Sep 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants