Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between iziToast and iziModal #122

Closed
Ramin-Bateni opened this issue Sep 2, 2017 · 7 comments
Closed

Conflict between iziToast and iziModal #122

Ramin-Bateni opened this issue Sep 2, 2017 · 7 comments

Comments

@Ramin-Bateni
Copy link

I used both iziToast and iziModal in a project but I think there are some conflict between them.

For example:

If I put iziToast.css below the iziModal.css it cause negative side effects on the animation of the background overlay of the opened modal [when i want close the modal].

and

If i put iziModal.css below the iziToast.css it cause negative side effects on opend notification (the title of notification is hide)!

You can see side effect of iziModal on title of iziToast in the bellow image (100% key-frame has zero opacity then it hide the title of toast notification):

image

Is there a patch for these conflicts?
Or should I use these tools with some special order and configs in this cases?

In addition: Hey @Dolce , I think your plugins are awesome! Bravo!

@marcelodolza
Copy link
Owner

Thanks @Ramin-Bateni! I'll analyze! 👊

@marcelodolza
Copy link
Owner

@Ramin-Bateni
Could you test, please?
iziModal + iziToast.zip

@Ramin-Bateni
Copy link
Author

Ramin-Bateni commented Sep 4, 2017

Of course, I tested it. 😉
It seems the problems are solved and the toast notifications and modals appears and hides properly (I wrote iziModal.css after iziToast.css in my test).
Thank you..

Apart from this issue:
A) I see 2 error in the Chrome console when I mouse over and mouse leave a toast notification:
image

B) Also I recommend Tahoma font for RTL languages. It is most popular font in the RTL websites.
For example 'Lato' and arial are exactly same view in Persian and Arabic languages and Tahoma has very better view than them to show Persian and Arabic words (RTL languages).

.iziToast-rtl {
    /*other styles here*/
   font-family: tahoma,'Lato',arial;
}
.iziToast-rtl .iziToast-body strong {
    /*other styles here*/
    font-size: 11px;
}
.iziToast-rtl .iziToast-body p {
    /*other styles here*/
    font-size: 11px;
}

Also I recommend Tahoma as default font every where in your plugins (iziToast & iziModal &...) for RTL mode.

Is it possible to you fix them?

@marcelodolza
Copy link
Owner

marcelodolza commented Sep 4, 2017

Yes, but I'm not seeing these errors in the console.
What are your settings?

@Ramin-Bateni
Copy link
Author

I tested both normal and minified versions of the js file. Both work the same way.

I found the error condition.
Please test it with timeout : 0 or timeout : false option.

iziToast.info({
	title:"My Title"
	,description:"My Description"
	,timeout : 0
});

image

@marcelodolza
Copy link
Owner

Now I've been able to replicate the issue.
See if it's working..
iziToast v1.2.0.zip

@Ramin-Bateni
Copy link
Author

Now it's OK
Thank you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants