Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Consistency fixes for pyfiction and the documentation #427

Merged
merged 18 commits into from
May 4, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented May 4, 2024

Description

This PR includes some polishing of pyfiction and the documentation.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added documentation Documentation is added or needed small fix Non-critical issue or inconsistency python Pull requests that update Python code labels May 4, 2024
@marcelwa marcelwa self-assigned this May 4, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (aba8072) to head (5bfabd7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         214      214           
  Lines       28873    28874    +1     
  Branches     1367     1368    +1     
=======================================
+ Hits        28358    28359    +1     
  Misses        515      515           
Files Coverage Δ
...on/algorithms/physical_design/hexagonalization.hpp 100.00% <100.00%> (ø)
...ithms/physical_design/post_layout_optimization.hpp 100.00% <100.00%> (ø)
...on/algorithms/physical_design/wiring_reduction.hpp 98.66% <100.00%> (ø)
.../algorithms/simulation/sidb/operational_domain.hpp 97.20% <100.00%> (+0.40%) ⬆️
include/fiction/layouts/cell_level_layout.hpp 100.00% <100.00%> (ø)
include/fiction/utils/layout_utils.hpp 98.96% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba8072...5bfabd7. Read the comment docs.

@marcelwa marcelwa merged commit e53229e into main May 4, 2024
44 checks passed
@marcelwa marcelwa deleted the pyfiction-consistency-fixes branch May 4, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation is added or needed python Pull requests that update Python code small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant