We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using Translations.byLocale, we should not need to provide the translations of the default locale like:
Translations.byLocale
var t = Translations.byLocale("en_US") + { "en_us": { "Hi.": "Hi.", "Goodbye.": "Goodbye.", }, };
This is boilerplate.
But if we don't provide it, an error is shown: ➜ There are no translations in 'en_US' for "Hi". This behavior should be fixed.
➜ There are no translations in 'en_US' for "Hi".
I have created #25 to fix this issue, please take a look of it. Thanks.
The text was updated successfully, but these errors were encountered:
This already works. The docs say: "Note above, since "en_us" is the default locale you don't need to provide translations for those".
But it was recording it as a missing translation. It should not. Good catch!
I've added tests, and I'm bumping the package version to 1.3.4. Thanks.
Sorry, something went wrong.
No branches or pull requests
When using
Translations.byLocale
, we should not need to provide the translations of the default locale like:This is boilerplate.
But if we don't provide it, an error is shown:
➜ There are no translations in 'en_US' for "Hi".
This behavior should be fixed.
I have created #25 to fix this issue, please take a look of it. Thanks.
The text was updated successfully, but these errors were encountered: