Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 has lower version code then v2.5 #84

Closed
jspricke opened this issue Jul 28, 2021 · 15 comments
Closed

v3.0 has lower version code then v2.5 #84

jspricke opened this issue Jul 28, 2021 · 15 comments

Comments

@jspricke
Copy link

v2.5 has versionCode 10:
2ae502d#diff-9526ccfd1d1813ed49c39f8c54dbeb512607376a007d824b905bc8b4e4d202d9L50

whereas v3.0 has versionCode 8:

versionCode: 8

This is not allowed in Android and the system refuses an upgrade. Due to this the Sharik version on F-Droid is still 2.5. Could you bump the version code to higher then 10 and tag a new version? Thanks!

@marchellodev
Copy link
Owner

Thanks! I have just created a new tag. Does this solve the issue?

@jspricke
Copy link
Author

Depends, normally flutter apps define the version code in pubspec.yaml, whereas you did it in the gradle file now. Is that on purpose?

@marchellodev
Copy link
Owner

Yeah, it's a temporary solution. For the next release, I will research how the flutterVersionCode.toInteger() and flutterVersionName work and base future gradle files on these functions instead.

@jspricke
Copy link
Author

Why not simply bump the version in the pubspec.yaml

@marchellodev
Copy link
Owner

Oh, right, I have just noticed that I could do just that. lol, my bad, sorry. That will work though, right?

@jspricke
Copy link
Author

yes 👍

@jspricke
Copy link
Author

Do you still push a new tag?

@marchellodev
Copy link
Owner

Is there a need for it?

@jspricke
Copy link
Author

F-Droid would automatically find and build that version without me fixing things ;).

@marchellodev
Copy link
Owner

Cool, thanks for opening the issue!

@jspricke
Copy link
Author

so will you push a tag or should I do stuff manually?

@marchellodev
Copy link
Owner

Sorry, what do you mean by pushing a tag? :>

@jspricke
Copy link
Author

jspricke commented Jul 28, 2021

A new tag where the pubspec.yaml has a higher version code.
As in new release.

@marchellodev
Copy link
Owner

Done https://github.com/marchellodev/sharik/blob/v3.0.1/pubspec.yaml

Do I also need to create a new release on Github?

@jspricke
Copy link
Author

jspricke commented Jul 28, 2021

Works for me now, thanks!
No need for Github releases, we only care for git tags ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants