Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date selector should allow easier switching of year #49

Closed
GoogleCodeExporter opened this issue Jul 16, 2015 · 7 comments
Closed

Date selector should allow easier switching of year #49

GoogleCodeExporter opened this issue Jul 16, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Add Date Field to Form
2. Try To change date 20 years back & forth (by example asking for date of
birth). Creator of form does not know where to set startvalue & user needs
to click too much to get from now to 1980

What is the expected output? What do you see instead?
Have a select box in the date selector to change year.

What version of the product are you using? On what operating system?
latest.

Please provide any additional information below.
I have this issue creating a registration form for a website.

Original issue reported on code.google.com by uwictpar...@gmail.com on 1 Jun 2010 at 7:01

@GoogleCodeExporter
Copy link
Author

Thanks for the feedback.  This is a known issue that we will be addressing in 
the near future.

Original comment by ajporterfield@gmail.com on 1 Jun 2010 at 6:36

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Glad to hear that. Thumbs up for the project so far. I like this form builder 
class a
lot!

Original comment by uwictpar...@gmail.com on 1 Jun 2010 at 6:44

@GoogleCodeExporter
Copy link
Author

The jquery ui datepicker has the options:
changeMonth
changeYear

You could add changeMonth: true, changeYear: true,  into the parameters of the
datepicker.

However I have found an unrelated bug where if you press "today" on the 
datepicker
dialog, the date is not actually entered into the field.

When the changeMonth and changeYear are turned on, when you select a year at 
the top
and dont click on a date at the bottom, the date does not change, which seems
awkward, and not how I would expect. I am assuming its just not setting the 
value
into the textbox properly.

Will have to look into that some more.

Original comment by moncojhr@gmail.com on 2 Jun 2010 at 1:48

@GoogleCodeExporter
Copy link
Author

Actually the today button is supposed to just take you to today's date so you 
can
select it... and the chooseMonth/Year are not supposed to fire...

Honestly the buttons turned on at the bottom seem quite useless, I would change:

    $("#{$form->jqueryDateIDArr[$d]}").datepicker({ dateFormat:
"{$form->jqueryDateFormat}", showButtonPanel: true });

to:

    $("#{$form->jqueryDateIDArr[$d]}").datepicker({ dateFormat:
"{$form->jqueryDateFormat}", changeMonth: true, changeYear: true });

which will give you the month and year selectors and not show the buttonPanel, I
would also get rid of the "click here to select a date" thing, and replace it 
with no
text and a calendar icon to the right of the text box.

Original comment by moncojhr@gmail.com on 2 Jun 2010 at 2:04

@GoogleCodeExporter
Copy link
Author

I don't mind that the month/year selectors don't fire the date selection. In my
opinion if someone wants to enter by example it's birth date, he doesn't want 
to fire
the date selector when changing years/month. He goes to the correct date/month 
and
then selects the date he wants. That last action should trigger date selection.

Your idea with putting a calendar icon next to the field is also a possibility, 
but
here we should take into account that positioning the icon should not ruin the 
layout
of the form (the date field should be shorter to take into account the icon 
size)

Original comment by uwictpar...@gmail.com on 2 Jun 2010 at 7:52

@GoogleCodeExporter
Copy link
Author

The latest working copy includes the changeMonth/changeYear options in the date 
and datetime elements.  This 
can be downloaded by running svn checkout 
http://php-form-builder-class.googlecode.com/svn/trunk/ php-
form-builder-class.

Because this is a working copy, and not a stable version release, it should be 
noted this falls under the "use at 
your own risk" category.

- Andrew

Original comment by ajporterfield@gmail.com on 2 Jun 2010 at 1:00

@GoogleCodeExporter
Copy link
Author

Original comment by ajporterfield@gmail.com on 2 Jun 2010 at 5:22

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant