forked from jlewallen/jenkins-hipchat-plugin
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When there is no config set there was an empty message being sent, instead make sure the defaults are used.
- Loading branch information
Marcin Szczepanski
committed
Feb 9, 2013
1 parent
2e33605
commit 333d376
Showing
1 changed file
with
4 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333d376
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use StringUtils.isBlank for checking if a string is .
I would also change the logger from warning to info.
Warning means: do something or it will might lead to a bug.
333d376
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback - the warnings aren't there in the latest commit, but I've changed the way I check for blank strings.