Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for some functionality of the crawler #75

Open
marco-c opened this issue Feb 20, 2018 · 4 comments
Open

Add tests for some functionality of the crawler #75

marco-c opened this issue Feb 20, 2018 · 4 comments
Labels

Comments

@marco-c
Copy link
Owner

marco-c commented Feb 20, 2018

Maybe moving some crawler code in a separate module under the autowebcompat directory.

@poush
Copy link
Contributor

poush commented Feb 20, 2018

I would like to work on this.

@marco-c
Copy link
Owner Author

marco-c commented Feb 20, 2018

I would like to work on this.

Sure, go ahead!

@poush
Copy link
Contributor

poush commented Feb 20, 2018

@marco-c Need some help here. So on checking collect.py, I think read_sequence, get_all_attributes, screenshot, set_timeouts can be moved to autowebcompat directory and can be added in test cases. but get_all_attributes, set_timeouts and screenshot is driver module dependent which they receive as parameter. So is it right way of doing this or should I think and try again?

@marco-c
Copy link
Owner Author

marco-c commented Feb 20, 2018

For the functions that get a webdriver as parameter, you can create a webdriver in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants