Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with NSS #4

Closed
ekr opened this issue Oct 4, 2018 · 1 comment
Closed

Doesn't work with NSS #4

ekr opened this issue Oct 4, 2018 · 1 comment
Assignees
@marco-c

Comments

@ekr
Copy link

ekr commented Oct 4, 2018

This is great, but it doesn't currently work with CLs from NSS. I think the problem is just that you need getSearchfoxPath() to produce the right searchfox path for NSS. I'm not sure what the right way to detect that case is, though.
@marco-c marco-c self-assigned this Oct 5, 2018
@marco-c
Copy link
Owner

marco-c commented Oct 5, 2018

I should be able to detect it parsing the Repository field from Phab.

@marco-c marco-c closed this as completed in cd97d11 Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-c marco-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekr @marco-c