Fix naming convention #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-venicius
requested changes
Apr 6, 2023
There was a problem hiding this comment.
when the proto names is changed another build should be generate.
when this is builded the c# compiler will generate classes to this services and requests.
so, you need to change on code too. (where the classes appears).
every place that use the c# version of the proto file should be changed to the new name.
i recomend you to build the application, you should see the errors that will be generated
marcos-venicius
assigned marcos-venicius and Soumya-Kushwaha and unassigned marcos-venicius
|
@marcos-venicius I guess I'll not be able to do stuff with C#. Sorry! |
|
no problem @Soumya-Kushwaha! you can contribute with another stuff with you fell confortable. I will close the pull request cause the changes are not complete. But, you can contribute to any other thing if you want. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10