Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe area is inherited from the device running Sizes #14

Open
fpg1503 opened this issue Oct 14, 2018 · 1 comment
Open

Safe area is inherited from the device running Sizes #14

fpg1503 opened this issue Oct 14, 2018 · 1 comment
Labels
enhancement New feature or request
Projects

Comments

@fpg1503
Copy link

fpg1503 commented Oct 14, 2018

Expected Behavior

When the size is changed to a new device, the view controller should have the same safe area that it would have if it were running on that device.

Actual Behavior

When the size is changed to a new device, the safe area does not change.

Steps to Reproduce the Problem

  1. Run Sizes on an iPhone 8 Plus
  2. Select Readme
  3. The safe area is small (ok)
  4. Change size to iPhone Xs
  5. The safe area remains small (not ok)
  6. For contrast, you can run Sizes on an iPhone Xs and see the difference:
iPhone 8 Plus Simulator iPhone Xs Simulator
iPhone 8 Plus Size simulator screen shot - iphone 8 plus - 2018-10-14 at 13 13 54 simulator screen shot - iphone xs - 2018-10-14 at 13 14 08
iPhone Xs Size simulator screen shot - iphone 8 plus - 2018-10-14 at 13 14 05 simulator screen shot - iphone xs - 2018-10-14 at 13 14 16

Specifications

  • Version: Any
  • Platform: Any
  • Subsystem: Any
@marcosgriselli marcosgriselli added enhancement New feature or request Hacktoberfest labels Oct 14, 2018
@marcosgriselli marcosgriselli added this to To do in Sizes via automation Oct 14, 2018
@marcosgriselli
Copy link
Owner

Thanks for creating this issue @fpg1503. I'm still to find a solution to the safe area issues but I'll add it to the TODO list 👍

Repository owner deleted a comment from BatyrOvezdurdyyev Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Sizes
  
To do
Development

No branches or pull requests

2 participants