Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matplotlib dependency #297

Closed
jamesmyatt opened this issue Mar 5, 2019 · 6 comments
Closed

matplotlib dependency #297

jamesmyatt opened this issue Mar 5, 2019 · 6 comments

Comments

@jamesmyatt
Copy link
Contributor

I see in setup.py that the matplotlib dependency is fixed at v2. Why is this? Why not also newer versions?
@marcotcr
Copy link
Owner

Good question, I don't remember. I removed the version requirement in e286bca

@marcotcr
Copy link
Owner

I remembered now, python2 installation fails if we don't fix the matplotlib dependency. If you install a newer version with python3 LIME still works though.

@jamesmyatt
Copy link
Contributor Author

Better to drop python 2 https://python3statement.org/

@jamesmyatt
Copy link
Contributor Author

See #303

@marcotcr
Copy link
Owner

I think the fix on f7f63fb solve this particular issue.
It would definitely be easier to drop python 2, but I don't think I'm ready to do it yet. Maybe in 2020 : )

@jamesmyatt
Copy link
Contributor Author

All of the other major machine learning libraries are already doing it for future feature releases, e.g. sklearn 0.21 and pandas 0.25 will only support Python 3.5 or newer.

@interpret-ml interpret-ml mentioned this issue May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcotcr @jamesmyatt