-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step 3 - Your first query #3
Comments
Submission: Commit your query via a Pull RequestThe first method to submit your query is via a Pull Request. Using a Pull request has several advantages:
However this workflow is bit more involved than just directly committing to master for the purposes of this course. To submit this query via Pull Request, you can follow the following workflow:
|
Submission: Commit your query directly to masterThis method is simpler. You won't have to juggle between branches, rebase onto master, or create Pull Requests. However, merging directly to master is not a good practice when you are contributing to a shared code base, so if you choose this method, please don't take this bad habit home with you! To submit this query via a direct commit to master, you can follow this workflow:
|
Congratulations, looks like the query you introduced in 2cfae6b finds the correct results! If you created a pull request, merge it. Let's continue to the next step. |
Step 3: Your first query
You will now run a simple CodeQL query, to understand its basic concepts and get familiar with your IDE.
⌨️ Activity: Run a CodeQL query
Edit the file
3_function_definitions.ql
with the following contents:Don't copy / paste this code, but instead type it slowly. You will see the CodeQL auto-complete suggestions in your IDE as you type.
from
and the first letters ofFunction
, the IDE will propose a list of available classes from the CodeQL library for C/C++. This is a good way to discover what classes are available to represent standard patterns in the source code.where f.
the IDE will propose a list of available predicates that you can call on the variablef
.getName()
to narrow down the list.Run this query: Right-click on the query editor, then click CodeQL: Run Query.
Inspect the results appearing in the results panel. Click on the result hyperlinks to navigate to the corresponding locations in the U-Boot code. Do you understand what this query does? You probably guessed it! This query finds all functions with the name
strlen
.Now it's time to submit your query. You will have 2 choices to do that, and we'll explain both of them in the comments below. Once you have chosen your method, submit your answer!
Read carefully: you will need to follow the same steps to submit your answers to later steps. You can always come back to this issue later to check the submission instructions.
The text was updated successfully, but these errors were encountered: