-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashed on Android with RN 0.34.1 #350
Comments
Downgrade to RN 0.32.1. I just tried most of the later versions, including 0.35.0-rc.0, and launchCamera() seems to crash hard on these later versions. 0.32.1 seems fine for me though. |
I can confirm @hasseio 's finding. It works on RN 0.32.1 but not on anything higher than that. |
Thanks for the help. With RN moving / changing so fast maybe listing which version a module was last confirmed to support should become a standard in developer documentation? Managing modules seems to be the biggest pain point right now. Great community might make up for it though. |
I just dug in on this personally for my own project, and found the format for customButtons must have changed. Previously I had specified options.customButtons = {
'Upload Video': 'upload_video',
} After changing it to the below it now works: options.customButtons = [
{ title: 'Upload Video', name: 'upload_video' },
]; |
Currently this package won't even compile, digging into it and providing a solution.
|
@robmoorman It compiles fine for me -- I'm using RN 0.34.1 I think you may have a separate issue. Probably best to open a new issue. This issue is about crashing at runtime. |
@robmoorman Try this. Make sure to run a gradle clean after the change. |
@pthrasher I'm not using custom buttons at all. |
I'm using version 0.21.5 and after upgrading to react native 0.34 the app is crashing every time that I select the "Choose from Library..." option. This is happening on Android and iOS. |
I'm having the same issue (crashes when picking Choose From Library option) but I've only tried it on iOS. I'm running RN v0.32.0. Happy to open a separate issue if it's not related to the same issue for Android. |
If this file has this line of code, you can try to comment.
` |
If you're having iOS issues it's likely related to the new iOS 10 permissions requirements. I successfully used this to solve it on iOS: |
In my experience you have to both add the permissions to the info.plist and explicitly request them using a method like the component uses above or the app will crash in iOS. |
Need an available version ASAP, pls. |
Thanks @dangnelson got it working with your suggestions! |
@lucassaldanha why are you using verson 0.21.5? The latest is 0.22.9, try upgrading. |
@dangnelson are you still having issues on Android? |
I'm about to try again, will let you know. |
Just got it working on a fresh project with RN 0.35.0 & image-picker 0.22.9 Only issue I ran into was permissions weren't added to the AndroidManifest.xml file automatically by react-native link |
Glad to hear it. Since you were the original poster and it's now working, I'm going to close this issue since it's gone kind of all over the place. If anyone else is still having an issue, please open a new one with your specific problem. |
Just leaving this here in case somebody has the same problem, I got an error:
if you get this problem, this is what worked for me: |
to add to ospfranco's comment: I figured out that another RN package was doing |
When running ImagePicker.showImagePicker the picker appears and allows me to make a selection, but the app crashes after I choose Library/Camera. It crashes before returning / logging anything.
The text was updated successfully, but these errors were encountered: