Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OscKernelKeyringBackend breaks keyring users which expect get_password() to return None or string #1

Open
wstephenson opened this issue Sep 1, 2022 · 0 comments

Comments

@wstephenson
Copy link

wstephenson commented Sep 1, 2022

Just spent a while debugging why gimme-aws-creds suddenly stopped working for me, and have narrowed it down to OscKernelKeyringBackend.get_password() returning _RetrieverFactory in the case of a non-existent password, as documented in osc.py. I installed osc for the first time on this machine recently and it apparently pulled in python310-keyring-keyutils.

Error, for search engines to find: TypeError: Object of type _PasswordRetriever is not JSON serializable

This behaviour is out of spec according to keyring's backend unit tests
Backends which don't have a password should only return None.

This breaks any program using keyring's default behaviour when no backend contains the password, because by default keyring sorts all backends by priority and tries them all in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant