Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin don't apply the filters everywhere #3

Closed
izendegi opened this issue Dec 1, 2022 · 3 comments
Closed

The plugin don't apply the filters everywhere #3

izendegi opened this issue Dec 1, 2022 · 3 comments

Comments

@izendegi
Copy link
Contributor

izendegi commented Dec 1, 2022

Hi,

We are testing this plugin (which is great, btw) and we've detected that there are some places inside the plugin where the Moodle filters aren't applied, at least these:

  • The assignment name in the breadcrumb
  • The course, the assignment and the rubric names in the header table
  • The rubric criteria and level definitions

irudia

@izendegi
Copy link
Contributor Author

izendegi commented Dec 1, 2022

I've just done a PR with the kind of stuff needed to support the filters: #4

@marcusgreen
Copy link
Owner

Hi izendegi, this is excellent, I had assumed you were commenting on Wordselect, which still doesn't process the mlang tags properly, especially if you use images. I was not aware/had not tested the advanced grading report properly with mlang (shame on me as someone who only speaks English). I will look at your code and get back to you as soon as possible.

@marcusgreen
Copy link
Owner

I forgot to close this, Merged into main on 1 Dec 2022, thank you izendegi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants