Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker tag -f deprecated in docker 1.10 #39

Closed
sherzberg opened this issue Feb 11, 2016 · 4 comments
Closed

docker tag -f deprecated in docker 1.10 #39

sherzberg opened this issue Feb 11, 2016 · 4 comments

Comments

@sherzberg
Copy link

You can now leave off the -f when tagging as it overwrites the previous no matter what. https://docs.docker.com/engine/deprecated/. Currently this just throws a warning, but soon will be removed.

https://github.com/marcuslonnberg/sbt-docker/blob/master/src/main/scala/sbtdocker/DockerTag.scala#L17

I don't see a supported docker version list. Thoughts on how to support the flag for older versions of Docker as well as newer?

@kurtkopchik
Copy link
Contributor

kurtkopchik commented May 17, 2016

I agree, it would be great if the plug-in supported the v1.12 Docker release which aims to remove this flag as well as the previous versions that do support it. Currently, it appears that sbt-docker will stop working once v1.12 of Docker is released.

@kurtkopchik
Copy link
Contributor

FYI @sherzberg I submitted a pull request with a fix for this issue.

@marcuslonnberg
Copy link
Owner

Will release a new version later today with #46 included.

@marcuslonnberg
Copy link
Owner

Version 1.4.0 have now been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants