Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-day events #1

Closed
jimmythom opened this issue Mar 4, 2021 · 9 comments · Fixed by #5
Closed

Multi-day events #1

jimmythom opened this issue Mar 4, 2021 · 9 comments · Fixed by #5
Labels
enhancement New feature request

Comments

@jimmythom
Copy link

I was waiting for something like this for a long time. Are you planning to improve it? For me would be very useful possibility to show multiday events. Thanks and good luck...

@marcusolsson
Copy link
Contributor

Thank you for the kind words! ❤️

I'm definitely up for improving the plugin. I've held off on new features until I've gotten some initial feedback on what would be useful.

Some thoughts on multiday events:

  • I think rather than multi-day, this really means support for events with a duration
  • This would probably mean defining a dimension for both start and end time
  • Start time would be required, but the end time dimension would be optional
  • If a user has defined a dimension for end times, what would a null value mean? Is the event still ongoing?

@jimmythom
Copy link
Author

It could be exactly how you wrote. Maybe the dimension for the end could be the same like the start dimension in case that it is event without duration. And if it is zero, its disabled event. But of course its up to you.
Another proposal to improve - if timestamp is only date (2021-03-04 00:00:00), mark it as wholeday event, if there is a different time, show it...

@andryyy
Copy link

andryyy commented Mar 10, 2021

Came to say the same: thank you!

For your thoughts and ideas: We can test whatever you implement. Sometimes it's easiest to just try and check what feels "good" and what feels "wrong". :)

@marcusolsson
Copy link
Contributor

Thank you both! ❤️

Just wanted to let you know that I'm (slowly) working on this. It's mostly done. Can hopefully push this once I've solved overlapping intervals.

Screenshot 2021-03-15 at 14 41 19@2x

@marcusolsson marcusolsson added this to To do in Grafana Plugins via automation Mar 16, 2021
@marcusolsson marcusolsson moved this from To do to In progress in Grafana Plugins Mar 16, 2021
@riaz85in
Copy link

Hi, I am a newbie to grafana. I downloaded the calendar plugin but after adding the panel to dashboard, the dimension field time and text are disabled. Also, on top of the panel it shows this error msg "Cannot read property 'fields' of undefined". Plz help.

@riaz85in
Copy link

16165083603116804081926025830807

@riaz85in
Copy link

16165084058068117042241697820989

@marcusolsson marcusolsson changed the title Thank you very much!!! Multi-day events Mar 24, 2021
@marcusolsson
Copy link
Contributor

@riaz85in It doesn't seem like your question is related to the feature request in the original post. If you have questions on how to use the plugin, please use the Discussions. That being said, try changing Format as to Table.

@riaz85in
Copy link

Hi, sorry. I posted in discussions. Plz help.

@marcusolsson marcusolsson mentioned this issue Apr 5, 2021
2 tasks
Grafana Plugins automation moved this from In progress to Done May 8, 2021
@marcusolsson marcusolsson removed this from Done in Grafana Plugins Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Development

Successfully merging a pull request may close this issue.

4 participants