-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should add comment to imply what browser uses what function #8
Comments
Hey alystair, That would be a great! I'd definitely pull a patch. Thanks for the suggestions. |
Actually I was hoping that you could add the commenting (since you originally created the script and know exactly what browser does what [hopefully]), so I could focus on index/length/push/pop :) |
Ah, I see. Well, the implementation is based on feature detection and I don't believe comments of which browser supports what method is necessary. For example, I don't see how implementation of a feature like index/length/push/pop would depend on which browser it is in if you can assume that the underlying get/set api works. If there is a web page with a table of support out there than linking to that in the readme could definitely be useful. I would very much appreciate if you took the time to find or make one! Cheers, |
Considering the implementation is feature detection based rather than browser detection, I don't think this is a relevant issue. Closing. Feel free to reopen with additional info/comments if you think it's importan.t |
. |
Right now looking at the code I have to guess which browser was implementing what code in the source. Would be nice to add comment per segment for ease of future modifications.
The text was updated successfully, but these errors were encountered: