add a readme for the example app #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
eduardborges
pushed a commit
to eduardborges/react-native-graph
that referenced
this pull request
Jun 11, 2022
feat: Add a readme for the example app (margelo#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue getting the iOS app to work. (
Error: Unable to resolve module @babel/runtime/helpers/interopRequireDefault)I looked at the babel config of the example app, and saw it was looking at the package.json at the root of the project (line 2:
const pak = require('../package.json')That might be the root cause of the issue with the iOS app not working unless you also
yarn installin the root of the project. This seems like a hacky workaround, and should probably instead make theexamplefolder independent of the root project, but...this is also a fast way to get people up and going with the example app until then.