feat: ability to customize SelectionDot component #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrousavy
approved these changes
Aug 5, 2022
Comment on lines
+27
to
+32
| runSpring(circleRadius, active ? 5 : 0, { | ||
| mass: 1, | ||
| stiffness: 1000, | ||
| damping: 50, | ||
| velocity: 0, | ||
| }) |
There was a problem hiding this comment.
I'd move that into the useAnimatedReaction, no need to add an extra callback here
|
LGTM thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current selection dot is 'design-wise' quite opinionated. It has a light shadow and an outer ring.
Instead of introducing a lot of new props (no offence #21) to customize the look-and-feel of the selection dot, I went for a flexible way to provide your own SelectionDot component.
Demo
Simulator.Screen.Recording.-.iPhone.13.-.2022-07-27.at.15.59.11.mp4
Simulator.Screen.Recording.-.iPhone.13.-.2022-07-27.at.15.58.39.mp4