Feat/support skia v0.1.233 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunrise1002 I would decrease the version to |
|
I guess I should have checked before I went and did the same thing haha #99
seems to be giving me a bit of trouble, getting host object errors |
|
@mrousavy @chrispader - I confirm this PR fixes the graph with the latest Skia version 0.1.241 |
|
I'll take a look in a few hours! |
|
Looks good! I think we can bump even further to latest, lgtm |
|
@mrousavy Hello! Will it be possible to make a new version in npm? |
|
Sure - done! |
katharine-river
added a commit
to katharine-river/react-native-graph
that referenced
this pull request
Jul 30, 2024
…ch (#3) * Update README.md * feat: Support skia v0.1.233 (margelo#96) * feat: Support skia v0.1.233 * feat: Support skia v0.1.233 * chore: release 1.1.0 * Lockfiles * chore: update skia version (#4) * chore: update skia version * fix: fix path interpolation animation --------- Co-authored-by: Marc Rousavy <me@mrousavy.com> Co-authored-by: sunrise1002 <tunglm.mar@gmail.com> Co-authored-by: katharine-river <132921466+katharine-river@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support skia v0.1.233