Fixed 2 buffer overflows in unittests

mariadb-corporation · Jan 26, 2018 · 058fc08 · 058fc08
1 parent 9ee1861
commit 058fc08
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/unittest/libmariadb/dyncol.c b/unittest/libmariadb/dyncol.c
@@ -153,10 +153,6 @@ static int create_dyncol_num(MYSQL *mysql)
   rc= mariadb_dyncol_unpack(&dyncol, &my_count, &my_keys, &my_vals);
   diag("unpack: %d %d", rc, my_count);
 
-  for(i=0; i < 5; i++)
-  {
-    diag("%s %lu", my_keys[i].str, (unsigned long)my_keys[i].length);
-  }
   free(my_keys);
   free(my_vals);
 

diff --git a/unittest/libmariadb/errors.c b/unittest/libmariadb/errors.c
@@ -242,7 +242,7 @@ static int test_parse_error_and_bad_length(MYSQL *mysql)
 
   rc= mysql_query(mysql, "SHOW DATABAAAA");
   FAIL_UNLESS(rc, "Error expected");
-  rc= mysql_real_query(mysql, "SHOW DATABASES", 100);
+  rc= mysql_real_query(mysql, "SHOW DATABASES\0AAA", 18);
   FAIL_UNLESS(rc, "Error expected");
 
   stmt= mysql_stmt_init(mysql);