[misc] ensure tracktrace results

mariadb-corporation · Mar 18, 2020 · 82717fd · 82717fd
1 parent f1d0924
commit 82717fd
Showing 1 changed file with 22 additions and 20 deletions.
diff --git a/src/main/java/org/mariadb/jdbc/internal/io/LruTraceCache.java b/src/main/java/org/mariadb/jdbc/internal/io/LruTraceCache.java
@@ -91,35 +91,37 @@ protected boolean removeEldestEntry(Map.Entry<String, TraceObject> eldest) {
    *
    * @return trace cache value
    */
-  public String printStack() {
+  public synchronized String printStack() {
     StringBuilder sb = new StringBuilder();
     boolean finished = false;
     while (!finished) {
       try {
         Map.Entry<String, TraceObject>[] arr = entrySet().toArray(new Map.Entry[0]);
         for (Map.Entry<String, TraceObject> entry : arr) {
           TraceObject traceObj = entry.getValue();
-          String key = entry.getKey();
-          String indicator = "";
+          if (traceObj.getBuf() != null) {
+            String key = entry.getKey();
+            String indicator = "";
 
-          switch (traceObj.getIndicatorFlag()) {
-            case TraceObject.COMPRESSED_PROTOCOL_NOT_COMPRESSED_PACKET:
-              indicator = " (compressed protocol - packet not compressed)";
-              break;
-            case TraceObject.COMPRESSED_PROTOCOL_COMPRESSED_PACKET:
-              indicator = " (compressed protocol - packet compressed)";
-              break;
-            default:
-              break;
-          }
-          sb.append("\nthread:").append(traceObj.getThreadId());
-          if (traceObj.isSend()) {
-            sb.append(" send at -exchange:");
-          } else {
-            sb.append(" read at -exchange:");
-          }
+            switch (traceObj.getIndicatorFlag()) {
+              case TraceObject.COMPRESSED_PROTOCOL_NOT_COMPRESSED_PACKET:
+                indicator = " (compressed protocol - packet not compressed)";
+                break;
+              case TraceObject.COMPRESSED_PROTOCOL_COMPRESSED_PACKET:
+                indicator = " (compressed protocol - packet compressed)";
+                break;
+              default:
+                break;
+            }
+            sb.append("\nthread:").append(traceObj.getThreadId());
+            if (traceObj.isSend()) {
+              sb.append(" send at -exchange:");
+            } else {
+              sb.append(" read at -exchange:");
+            }
 
-          sb.append(key).append(indicator).append(Utils.hexdump(traceObj.getBuf()));
+            sb.append(key).append(indicator).append(Utils.hexdump(traceObj.getBuf()));
+          }
         }
         finished = true;
       } catch (ConcurrentModificationException cc) {