Fix for CONPY-62:

When using binary protocl (which is forced when using a placeholder), the type NEW_DECIMAL was ignored and internally converted as string instead of Decimal.
mariadb-corporation · May 5, 2020 · 87684a1 · 87684a1
1 parent d35d172
commit 87684a1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/src/mariadb_codecs.c b/src/mariadb_codecs.c
@@ -473,7 +473,6 @@ field_fetch_fromtext(MrdbCursor *self, char *data, unsigned int column)
         case MYSQL_TYPE_NEWDECIMAL:
         {
             PyObject *decimal;
-
             decimal= PyObject_CallFunction(decimal_type, "s", (const char *)data);
             self->values[column]= decimal;
             break;
@@ -692,13 +691,24 @@ field_fetch_callback(void *data, unsigned int column, unsigned char **row)
                 *row+= length;
                 break;
             }
+        case MYSQL_TYPE_NEWDECIMAL:
+            {
+                unsigned long length= mysql_net_field_length(row);
+
+                if (length > 0)
+                {
+                    self->values[column]= PyObject_CallFunction(decimal_type, "s", (const char *)*row);
+                } else {
+                    self->values[column]= PyObject_CallFunction(decimal_type, "s", "0");
+                }
+                break;
+            }
         case MYSQL_TYPE_GEOMETRY:
         case MYSQL_TYPE_STRING:
         case MYSQL_TYPE_VAR_STRING:
         case MYSQL_TYPE_JSON:
         case MYSQL_TYPE_VARCHAR:
         case MYSQL_TYPE_DECIMAL:
-        case MYSQL_TYPE_NEWDECIMAL:
         case MYSQL_TYPE_SET:
         case MYSQL_TYPE_ENUM:
             {

diff --git a/src/mariadb_cursor.c b/src/mariadb_cursor.c
@@ -941,7 +941,6 @@ MrdbCursor_fetchone(MrdbCursor *self)
                 "Cursor doesn't have a result set");
         return NULL;
     }
-
     if (MrdbCursor_fetchinternal(self))
     {
         Py_INCREF(Py_None);

diff --git a/test/integration/test_cursor.py b/test/integration/test_cursor.py
@@ -918,5 +918,14 @@ def test_conpy61(self):
 
         del cursor
 
+    def test_conpy62(self):
+        con= create_connection()
+        cur = con.cursor()
+        con= create_connection()
+        query = "select round(.75 * (? / 3), 2) as val"
+        cur.execute(query,[5])
+        row= cur.fetchone()
+        self.assertEqual(row[0], Decimal(1.25))
+
 if __name__ == '__main__':
     unittest.main()