Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background prerequisites should obey :times #129

Open
marick opened this issue Apr 24, 2012 · 3 comments
Open

background prerequisites should obey :times #129

marick opened this issue Apr 24, 2012 · 3 comments
Milestone

Comments

@marick
Copy link
Owner

marick commented Apr 24, 2012

Right now, a background prerequisite always is implicitly tagged with :times (range 0). If a user explicitly specifies a :times, that should be obeyed.

@marick
Copy link
Owner Author

marick commented May 10, 2012

I'm disliking this idea now. For a provided prerequisite, it's clear where the how-many-times-called check happens. When does the check for a wrapping background check happen? At exit from the fact? I think the complexity is unwarranted for a feature not-that-often used.

@marick
Copy link
Owner Author

marick commented Jan 16, 2013

I'm consolidating all these "background" features into one report that will serve as a reference for the rewrite.

@philomates
Copy link
Collaborator

philomates commented Nov 13, 2017

Reopening because I think it is worth looking into addressing.

I've seen some tests that use :times with against-background, which basically doesn't do anything, so it would be good to get this sorted to prevent confusion and make sure tests are checking what they expect to check

If going for a fix of this behavior, worth looking at #54 as well

@philomates philomates reopened this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants