Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug dans SimplePie Sanitize pour </body> #159

Closed
Alkarex opened this issue Sep 12, 2013 · 2 comments
Closed

Bug dans SimplePie Sanitize pour </body> #159

Alkarex opened this issue Sep 12, 2013 · 2 comments
Assignees

Comments

@Alkarex
Copy link
Member

Alkarex commented Sep 12, 2013

Bug dans SimplePie Sanitize constaté pour le flux de "A List Apart":
alistapart

J'ai mis une copie sur http://test.alapetite.fr/alistapart.rss.xml

La partie problématique :

<description>&lt;p&gt;I make websites for mobile phones.
...
&lt;p&gt;Nah. The do-less future is not about creating a great dumbing down, but instead making sure the pile of technical tasks required to get a decent site or app out the door doesn’t smother us entirely.&lt;/p&gt;
&lt;/body&gt;&lt;p&gt;&lt;/html&gt;&lt;/p&gt;&lt;img src="http://feeds.feedburner.com/~r/alistapart/main/~4/uiOmXMBb6ws" height="1" width="1"/&gt;</description>

Je pense que le XPath utilisé ligne 457 de SimplePie/Sanitize.php ne marche pas dans ce cas, car il y a du contenu après un /body :

$elements = $xpath->query('body//' . $tag);

Je n'ai pas l'impression que SimplePie ait de patch en cours pour ce problème https://github.com/simplepie/simplepie/issues
Si je trouve le temps dans quelques jours, j'essayerai de proposer un patch pour SimplePie et/ou FreshRSS.

@Alkarex
Copy link
Member Author

Alkarex commented Sep 12, 2013

Corrigé par #160
Pourrait peut-être être mieux fait, mais semble bien convenir.

@Alkarex Alkarex closed this as completed Sep 12, 2013
Alkarex added a commit to Alkarex/simplepie that referenced this issue Apr 5, 2015
From September 2013.
SimplePie did not sanitize closing </body> and </html> tags.
FreshRSS/FreshRSS#159
FreshRSS/FreshRSS#160
@Alkarex
Copy link
Member Author

Alkarex commented Apr 6, 2015

simplepie/simplepie#395

@Alkarex Alkarex self-assigned this May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant