Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create user with SQLite #574

Closed
marienfressinaud opened this issue Aug 9, 2014 · 8 comments
Closed

Cannot create user with SQLite #574

marienfressinaud opened this issue Aug 9, 2014 · 8 comments
Assignees
Milestone

Comments

@marienfressinaud
Copy link
Member

I try to create a second user for my tests but I can't with SQLite on a fresh install.

I think the problem comes from we try to create new tables on the SQLite file of current user. Since we don't use prefix, tables already exist!

@marienfressinaud marienfressinaud added this to the 0.8.0 milestone Aug 9, 2014
@marienfressinaud
Copy link
Member Author

Moreover, I don't really like the code we use in FreshRSS_UserDAO::createUser(): it is the same as in install.php but the condition if (defined('SQL_CREATE_TABLES')) { ... } else { ... } is quite non-understable at the first glance…

@Alkarex
Copy link
Member

Alkarex commented Aug 9, 2014

Every user is supposed to have its own .sqlite file.
This is probably a file creation problem or something similar

@Alkarex Alkarex self-assigned this Aug 9, 2014
Alkarex added a commit that referenced this issue Aug 9, 2014
Not tested much yet. Some MySQL parts changed a bit too to double-check.
#574
@Alkarex
Copy link
Member

Alkarex commented Aug 9, 2014

Patch d477373
Pas encore trop testé. Il faudra vérifier MySQL aussi, et install.php #575

@Alkarex
Copy link
Member

Alkarex commented Aug 9, 2014

Should be good now, but we have to double-check MySQL and install.php as part of #575

@Alkarex Alkarex closed this as completed Aug 9, 2014
@marienfressinaud
Copy link
Member Author

It still not works :( I have an error and logs show:

[Sat Aug 09 20:00:47 2014] [error] [client 172.17.42.1] PHP Notice:  Undefined variable: ok in /var/www/html/app/Models/UserDAO.php on line 24, referer: http://localhost/p/i/?c=configure&a=users
[Sat Aug 09 20:00:47 2014] [error] [client 172.17.42.1] PHP Notice:  Undefined variable: stm in /var/www/html/app/Models/UserDAO.php on line 27, referer: http://localhost/p/i/?c=configure&a=users

Edit: and in FRSS logs: SQL error : syntax error

@marienfressinaud
Copy link
Member Author

Oops, sorry, I have updated FRSS on my server and tried on my computer >< It works now!

@Alkarex
Copy link
Member

Alkarex commented Aug 9, 2014

You probably have an old version of UserDAO.php

@Alkarex
Copy link
Member

Alkarex commented Aug 9, 2014

Ok :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants