Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST for "mark (all) as read" #599

Closed
3 tasks done
Alkarex opened this issue Aug 30, 2014 · 5 comments
Closed
3 tasks done

Use POST for "mark (all) as read" #599

Alkarex opened this issue Aug 30, 2014 · 5 comments
Assignees
Milestone

Comments

@Alkarex
Copy link
Member

Alkarex commented Aug 30, 2014

Only for the global actions affecting many articles.
See #554 (comment) and #570

  • Replace the <a> links by corresponding <button formmethod="post"> buttons
  • Use POST in the JavaScript too
  • Allow only POST in the PHP controller.
@Alkarex Alkarex added this to the 0.8.0 milestone Aug 30, 2014
@marienfressinaud
Copy link
Member

What about links in dropdown menu? Using buttons will break the design and I would like to avoid using CSS to make buttons looking like links.

@Alkarex
Copy link
Member Author

Alkarex commented Sep 15, 2014

A set of CSS rules for the buttons such as background:transparent; color:inherit; border:none; should be sufficient, so it is not so much, luckily.
Furthermore, the current <a/> links in the menus are a bit abused, since there are almost styled as a button (block element with some centred text and the background changing during hovering).
Semantically, <a/> is also not so appropriate for such an action.
If we do not want to use any CSS at all and keep using <a/> for POSTing, then it is also doable to catch the link and POST with JavaScript, but I would rather avoid that :-/

@marienfressinaud
Copy link
Member

Not so easy, but it should work now :)

@marienfressinaud
Copy link
Member

Still a problem with #bigMarkAsRead link

@Alkarex
Copy link
Member Author

Alkarex commented Sep 17, 2014

Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants