Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] caret does not respect widget added using addLineWidget #925

Closed
pavelfeldman opened this issue Nov 4, 2012 · 3 comments
Closed

[v3] caret does not respect widget added using addLineWidget #925

pavelfeldman opened this issue Nov 4, 2012 · 3 comments

Comments

@pavelfeldman
Copy link
Contributor

I can see the widget added, but as I move the cursor around, I can see that cursor does not respect the widget. Making the widget 1.5 line height clearly manifests it.
@marijnh
Copy link
Member

marijnh commented Nov 5, 2012

Can you provide a test case? I can't reproduce this on http://codemirror.net/demo/widget.html , even when setting the widgets to have a higher height.

@marijnh
Copy link
Member

marijnh commented Nov 29, 2012

This may be a real bug, but without any further information, there's not much I can do with it. Closing until further notice.

@marijnh marijnh closed this as completed Nov 29, 2012
marijnh added a commit that referenced this issue Jan 2, 2013
@marijnh
Add overflow: auto to line widget wrapper to prevent margin leaking
42ab247 
(If the widget had a margin, that margin would end up outside the wrapper, throwing off
line height measurement.)

Might be related to issue #925
@marijnh
Copy link
Member

marijnh commented Jan 2, 2013

I think I found a similar symptom when creating a widget with vertical margins. The above patch should fix that. (Still might be a different bug.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @pavelfeldman