Add option to make tern completions synchronous.

[renatofdds]

With this option on there is no need to bind a separate key specifically
for tern-ac-complete, it will be queried automatically by auto-complete
and list completions along with other ac-sources.

[marijnh]

I'm out of my emacs-depth here -- I don't really understand what is being done and why.

@kiwanami Do you have an opinion on this patch?

[renatofdds]

Advising functions is the emacs easy way to attach functionality before, around, or after an already existent function.

This patch advises auto-complete so It waits for tern to obtain its suggestions from the server before popping up.

-----Original Message-----
From: Marijn Haverbeke notifications@github.com
To: marijnh/tern tern@noreply.github.com
Cc: Renato F renatofdds@gmail.com
Sent: Thu, 28 May 2015 5:30 AM
Subject: Re: [tern] Add option to make tern completions synchronous. (#546)

I'm out of my emacs-depth here -- I don't really understand what is being done and why.

@kiwanami Do you have an opinion on this patch?

---

Reply to this email directly or view it on GitHub:
#546 (comment)

[kiwanami]

Hi, @renatofdds @marijnh
I'll check this code.

[kiwanami]

I have checked. The action for synchronous command moves good.

In this PR, the default value of customize variable tern-ac-sync is t.
Though this code changes completion behavior, I think almost users feel this interaction reasonable.

One point, at the advice auto-complete, some major mode symbols are hard coded.
I think it should be extracted as a customize (or just defvar) variable to maintenance easily, because the popular major mode would change in the future.

Then, we should merge this code!

[renatofdds]

Thank you @kiwanami.
I agree with extracting the major modes into a defcustom.

[marijnh]

Merged as 4f24418 and followed up with fba7909