New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SaveAndMergeAsync method in editable base types #993

Closed
rockfordlhotka opened this Issue Nov 14, 2018 · 0 comments

Comments

Projects
1 participant
@rockfordlhotka
Copy link
Member

rockfordlhotka commented Nov 14, 2018

There should be a better abstraction for use of GraphMerger in the form of a SaveAndMergeAsync method on BusinessBase and BusinessListBase. This enables UI code like:

await Model.SaveAndMergeAsync();

The implementation should be something like this (in a list type):

        public async Task SaveAndMergeAsync()
        {
            var saved = await SaveAsync();
            var merger = new Csla.Core.GraphMerger();
            merger.MergeBusinessListGraph<Family, Child>(this, saved);
        }

@rockfordlhotka rockfordlhotka self-assigned this Nov 14, 2018

@rockfordlhotka rockfordlhotka added this to To do in Version 4.9.0 via automation Nov 14, 2018

rockfordlhotka added a commit to rockfordlhotka/csla that referenced this issue Nov 20, 2018

@rockfordlhotka rockfordlhotka moved this from To do to In progress in Version 4.9.0 Nov 20, 2018

Version 4.9.0 automation moved this from In progress to Done Nov 20, 2018

itgoran added a commit to itgoran/csla that referenced this issue Nov 21, 2018

rockfordlhotka added a commit that referenced this issue Nov 21, 2018

#967 Load configuration from appsettings.json (#994)
Closes #967 

* #967 Load configuration from appsettings.json

Load configuration for csla using 'csla' section from appsettings.json file.
Add tests for testing configurations.

* #967 Reset global conf after tests

* Update to reflect v4.9 projects and directives

* Update CompilerDirectives.md

* #961 Move implementation of Dashboard to new branch (old branch was based on wrong base)

* #961 Fix configuration reset issues with cached dashboard object

* #966 CslaConfiguration methods need to return ICslaConfiguration

* #961 Maintain timer state on a per-request basis via ClientContext

* #966 Add missing using statements

* #966 Fix issues where not all settings were being reset properly

* Refine the tests excluded from Live Testing

* Fix incorrect namespace

* Fix name conflict

* #961 Implement IDisposable and properly dispose of timers

* #961 Change tests to use async Task and Task.Delay

* #961 Change timer settings

* #961 Ignore tests that pass except on Appveyor

* Update to reflect v4.9 projects and directives

* #993 Implement SaveAndMergeAsync methods

* #995 Add DefaultProxy overload to allow Type to be passed

* #967 Configurations are written into AppSettings

All configurations are written into ConfigurationManager.AppSettings
Add clean context before and after tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment