You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow-on to issue #265. Being a huge fan of consistency I loved that change. I am curious about two things:
I notice that the close event on View isn't standardized; it triggers 'Close' when it closes, while all other actions trigger some form of a past-tense event, e.g. 'Closed'.
Not all 'actionCompleted' events have a corresponding 'before' event; generally these events don't seem like places where there's value in such thing, but you never can say for sure (there's been numerous times where I wished there was a 'beforeInitialize' event!) To improve consistency and adhere to the principle of least astonishment is it worth the extra overhead to trigger events on actions like 'beforeItemAdded'?
As an aside, the naming convention for before and after events, 'beforeAction' / 'actioned', strikes me unbalanced; 'beforeAction' / 'afterAction' seems like it would have been a little cleaner.
The text was updated successfully, but these errors were encountered:
This is a follow-on to issue #265. Being a huge fan of consistency I loved that change. I am curious about two things:
As an aside, the naming convention for before and after events, 'beforeAction' / 'actioned', strikes me unbalanced; 'beforeAction' / 'afterAction' seems like it would have been a little cleaner.
The text was updated successfully, but these errors were encountered: