Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve event naming consistency #326

Closed
ccamarat opened this issue Oct 27, 2012 · 3 comments
Closed

Improve event naming consistency #326

ccamarat opened this issue Oct 27, 2012 · 3 comments

Comments

@ccamarat
Copy link
Contributor

This is a follow-on to issue #265. Being a huge fan of consistency I loved that change. I am curious about two things:

  1. I notice that the close event on View isn't standardized; it triggers 'Close' when it closes, while all other actions trigger some form of a past-tense event, e.g. 'Closed'.
  2. Not all 'actionCompleted' events have a corresponding 'before' event; generally these events don't seem like places where there's value in such thing, but you never can say for sure (there's been numerous times where I wished there was a 'beforeInitialize' event!) To improve consistency and adhere to the principle of least astonishment is it worth the extra overhead to trigger events on actions like 'beforeItemAdded'?

As an aside, the naming convention for before and after events, 'beforeAction' / 'actioned', strikes me unbalanced; 'beforeAction' / 'afterAction' seems like it would have been a little cleaner.

@mbriggs
Copy link
Contributor

mbriggs commented Nov 18, 2012

Agree with pretty much everything here, I don't mind making the changes if it gets a 👍 from @derickbailey

@mxriverlynn
Copy link
Member

👍

@cobbweb
Copy link
Member

cobbweb commented Jan 14, 2014

Closing this as a duplicate has popped up that already has some good discussion.

@cobbweb cobbweb closed this as completed Jan 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants