v5 Migration #3679
v5 Migration #3679
Conversation
| return onceCallback; | ||
| } | ||
|
|
||
| // a custom event channel. You may bind a callback to an event with `on` or |
There was a problem hiding this comment.
Below is a refactored version of Backbone's Events
| @@ -17,7 +17,31 @@ var proxy = function proxy(method) { | |||
|
|
|||
| // Marionette.extend | |||
|
|
|||
| var extend = Backbone.Model.extend; | |||
| function extend (protoProps, staticProps) { | |||
There was a problem hiding this comment.
Copied from Backbone
|
|
||
| // Event Delegator | ||
|
|
||
| function setEventDelegator(mixin) { |
There was a problem hiding this comment.
The event delegator handles DOM event delegation and was copied from Backbone.View
| return this; | ||
| } | ||
| var DomApi = { | ||
| // Returns a new HTML DOM node of tagName |
There was a problem hiding this comment.
DOM Api was updated to remove jquery by default as $el is no longer cached on the view
| Dom: DomApi, | ||
| // Create an element from the `id`, `className` and `tagName` properties. | ||
| _getEl: function _getEl() { |
There was a problem hiding this comment.
copied/modified from Backbone.View
|
|
||
| _.extend(ViewMixin, BehaviorsMixin, CommonMixin, DelegateEntityEventsMixin, TemplateRenderMixin, TriggersMixin, UIMixin); | ||
|
|
||
| function isView(view) { |
There was a problem hiding this comment.
New way of determining what a view is. Rather than depending on prototypal inheritance, anything that supports the API used by Marionette will be attempted.
| if (this.$el.length > 1) { | ||
| this.$el = this.Dom.getEl(this.el); | ||
| } | ||
| this.el = this.getEl(el); |
There was a problem hiding this comment.
$el is no longer cached on Regions
|
|
||
| this._initBehaviors(); | ||
| this.preinitialize.apply(this, arguments); |
There was a problem hiding this comment.
Bb's preinitialize added to views
paulfalgout
force-pushed
the
v5-migration-example
branch
from
ae073ed
to
d2e56be
Compare
DO NOT MERGE This PR serves as a migration guide for moving to https://github.com/marionettejs/marionette with the exception of Radio integration. But it should make relevent breaking changes more obvious
paulfalgout
force-pushed
the
v5-migration-example
branch
from
d2e56be
to
e782b4a
Compare
DO NOT MERGE
This PR serves as a migration guide for moving to https://github.com/marionettejs/marionette with the exception of Radio integration.
But it should make relevent breaking changes more obvious