Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also analyse tests with Psalm #17

Closed
mariosimao opened this issue Nov 6, 2021 · 0 comments · Fixed by #45
Closed

Also analyse tests with Psalm #17

mariosimao opened this issue Nov 6, 2021 · 0 comments · Fixed by #45
Assignees
@mariosimao
Labels
enhancement New feature or request
Projects
Notion PHP SDK
Milestone
v0.2.0

Comments

@mariosimao
Copy link
Owner

You should also cover your tests

Originally posted by @Ocramius in #6 (comment)
@mariosimao mariosimao added the enhancement New feature or request label Nov 6, 2021
@mariosimao mariosimao added this to To do in Notion PHP SDK Nov 7, 2021
@mariosimao mariosimao moved this from To do to In progress in Notion PHP SDK Nov 19, 2021
@mariosimao mariosimao self-assigned this Nov 20, 2021
@mariosimao mariosimao added this to the v0.2.0 milestone Nov 20, 2021
@mariosimao mariosimao mentioned this issue Nov 20, 2021
Merged
@mariosimao mariosimao linked a pull request Nov 20, 2021 that will close this issue
Psalm on tests #45
Merged
Notion PHP SDK automation moved this from In progress to Done Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariosimao mariosimao

Labels
enhancement New feature or request
Projects
No open projects
Notion PHP SDK
  
Done
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Psalm on tests mariosimao/notion-sdk-php
1 participant
@mariosimao