Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with null termination on command line arguments #15

Closed
ChibiDenDen opened this issue Oct 22, 2016 · 0 comments
Closed

Issue with null termination on command line arguments #15

ChibiDenDen opened this issue Oct 22, 2016 · 0 comments

Comments

@ChibiDenDen
Copy link

There is an issue iv'e encountered in at least one location in the win32 api.

In kernel32.py line 3857:
using max(MAX_PATH, len(lpCommandLine)) will create a string without a null terminator
this creates invalid command lines since the command line will contain heap garbage appended to it
using max(MAX_PATH, len(lpCommandLine+1)) should fix the issue here.

the same happenes in lines 3900 (using +2 should fix the issue here, i think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant