Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Update Package' feature makes mistake when there is a comment in front of version number #60

Closed
easazade opened this issue Sep 28, 2020 · 0 comments · Fixed by #70
Closed
Labels
bug Something isn't working
Milestone

Comments

@easazade
Copy link

'Update Package' feature makes mistake when there is a comment in front of version number

whenever there is a comment in front of the dependency in pubspec.yaml the it will be mistaken as dependency not being
the latest version

feather_icons_flutter: ^4.7.4 # https://feathericons.com/

eg in above dependency the text after # which is # https://feathericons.com/ is highlighted as warning and recommends the options to update version, event though the package is the latest version or not. actually it doesn't matter what the version is it'll just check the text after # (comment).

in example above if we use the update package options recommended by plugin the result will be like this :

feather_icons_flutter: ^4.7.4 ^4.7.4
@easazade easazade added the bug Something isn't working label Sep 28, 2020
@marius-h marius-h added this to the v1.4 milestone Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants