Handling for ping events

[maxbrunsfeld]

Right now, my RightHook::App (you know the one) occasionally gets its on_issue method called with a nil value for the third argument (issue_json). I think this is because of the ping event, which sends to every webhook a payload like this:

{
  "zen": "Non-blocking is better than blocking.",
  "hook_id": 2341839
}

with this header:

X-GitHub-Event: ping

So even though the subscription is for issue events, we sometimes get json without an issue key.

One option would be for my app to just handle the case of nil json itself, but maybe it should be built into right_hook. What do you think?

[mark-rushakoff]

According to the Webhooks page:

When you create a new webhook, we’ll send you a simple ping event to let you know you’ve set up the webhook correctly.

It sounds like right_hook indeed should handle that correctly. Pull requests are very welcome.